Skip to content

Update .asf.yaml: keep stale reviews on PRs targeting master - #14425

Merged
merlimat merged 1 commit into
apache:masterfrom
michaeljmarshall:keep-stale-reviews
Feb 23, 2022
Merged

Update .asf.yaml: keep stale reviews on PRs targeting master#14425
merlimat merged 1 commit into
apache:masterfrom
michaeljmarshall:keep-stale-reviews

Conversation

@michaeljmarshall

@michaeljmarshall michaeljmarshall commented Feb 23, 2022

Copy link
Copy Markdown
Member

Motivation

In #14226, I set this value to true. The previous setting was false.

Mailing list discussion: https://lists.apache.org/thread/0czyvl5csjnpcm0hvq4t8j2qxk2t2620

Modifications

  • Don't dismiss stale code reviews

@michaeljmarshall michaeljmarshall added the doc-not-needed Your PR changes do not impact docs label Feb 23, 2022
@michaeljmarshall michaeljmarshall self-assigned this Feb 23, 2022
@merlimat
merlimat merged commit be3f855 into apache:master Feb 23, 2022
@michaeljmarshall
michaeljmarshall deleted the keep-stale-reviews branch February 23, 2022 16:27
nicoloboschi pushed a commit to nicoloboschi/pulsar that referenced this pull request Mar 1, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants